Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pectra PGR #400

Merged
merged 25 commits into from
Feb 3, 2025
Merged

Pectra PGR #400

merged 25 commits into from
Feb 3, 2025

Conversation

corwintines
Copy link
Member

No description provided.

@corwintines corwintines marked this pull request as draft January 21, 2025 20:54
@corwintines corwintines changed the title Pectra PGR [WIP] Pectra PGR Jan 21, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @corwintines. Left a few comments.

src/components/forms/PectraPGRForm.tsx Outdated Show resolved Hide resolved
src/components/forms/schemas/PectraPGR.ts Show resolved Hide resolved
src/components/forms/schemas/PectraPGR.ts Outdated Show resolved Hide resolved
src/components/forms/schemas/PectraPGR.ts Show resolved Hide resolved
src/components/forms/schemas/PectraPGR.ts Outdated Show resolved Hide resolved
@corwintines corwintines marked this pull request as ready for review January 31, 2025 05:03
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corwintines looks good. Found a few issues with the schema validations.

src/components/forms/PectraPGRForm.tsx Show resolved Hide resolved
src/components/forms/schemas/PectraPGR.ts Outdated Show resolved Hide resolved
src/components/forms/schemas/PectraPGR.ts Outdated Show resolved Hide resolved
@corwintines corwintines changed the title [WIP] Pectra PGR Pectra PGR Feb 3, 2025
pettinarip
pettinarip previously approved these changes Feb 3, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corwintines corwintines merged commit 1dd41b0 into master Feb 3, 2025
5 checks passed
@corwintines corwintines deleted the pectra-pgr branch February 3, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants