Skip to content

Conversation

@0xLogicalx
Copy link

replace the incorrect x.to_bytes(...) / y.to_bytes(...) calls with direct concatenation of the sliced byte values in verify ensure the documentation example returns the expected 64-byte public key without triggering an AttributeError

@0xLogicalx 0xLogicalx requested a review from eth-bot as a code owner November 12, 2025 22:25
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Nov 12, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 12, 2025

File EIPS/eip-8030.md

Requires 1 more reviewers from @SirSpudlington

@eth-bot eth-bot added the a-review Waiting on author to review label Nov 12, 2025
@eth-bot eth-bot changed the title Remove invalid byte conversion in EIP-8030 verify example Update EIP-8030: Remove invalid byte conversion in EIP-8030 verify example Nov 12, 2025
@SirSpudlington
Copy link
Contributor

The .to_bytes(32, "big") is there to explicitly state that the output is concatination not addition. EIP code is used to define how algorithms work, and is rarely used directly.

Similarly, you have opened two superfluous PRs for the same EIP. Please stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants