This repository was archived by the owner on Apr 24, 2022. It is now read-only.
Fix lack of uniqueId on AMD GPU OpenCL without AMD extensions#2333
Open
pjakma wants to merge 2 commits intoethereum-mining:masterfrom
Open
Fix lack of uniqueId on AMD GPU OpenCL without AMD extensions#2333pjakma wants to merge 2 commits intoethereum-mining:masterfrom
pjakma wants to merge 2 commits intoethereum-mining:masterfrom
Conversation
AMD GPU systems need not have a functional clGetDeviceInfo(..., CL_DEVICE_TOPOLOGY_AMD, ...). E.g., Fedora OpenCL with AMD GPU drivers, it seems. As the code stands it doesn't create a uniqueId, and leaves it null. If there are multiple GPUs, the device info is stored to null uniqueId and overwritten - and only one of these GPUs will be enumerated and visible to the miner. Fix this by providing a fall-back, constructing the uniqueId from the platform and device indexes. As is already the case for Intel GPU and CPU devices. Additionally, cosmetically, add a clearer, more self-describing struct for the AMD topology data.
The hard coded 1.66.0 Boost in Hunter no longer downloads, breaking the build. Change to the default hunter version.
Author
|
Ping, anyone able to have a look? |
Ahmadchurra681
approved these changes
Aug 5, 2021
Ahmadchurra681
approved these changes
Aug 5, 2021
Ahmadchurra681
approved these changes
Aug 5, 2021
Ahmadchurra681
approved these changes
Aug 5, 2021
Ahmadchurra681
approved these changes
Aug 11, 2021
Ahmadchurra681
approved these changes
Aug 11, 2021
Ahmadchurra681
approved these changes
Aug 11, 2021
theg4sh
approved these changes
Nov 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD GPU systems need not have a functional
clGetDeviceInfo(..., CL_DEVICE_TOPOLOGY_AMD, ...).
E.g., Fedora OpenCL with AMD GPU drivers, it seems. As the code stands it
doesn't create a uniqueId, and leaves it null. If there are multiple GPUs,
the device info is stored to null uniqueId and overwritten - and only one of
these GPUs will be enumerated and visible to the miner.
Fix this by providing a fall-back, constructing the uniqueId from the
platform and device indexes. As is already the case for Intel GPU and CPU
devices.
Additionally, cosmetically, add a clearer, more self-describing struct for
the AMD topology data.
To get Hunter to work I had to update the Boost version.
The previously specified version is no longer available for hunter to download.