Always send periodic progress requsts when collecting events.#21546
Always send periodic progress requsts when collecting events.#21546serathius wants to merge 1 commit intoetcd-io:mainfrom
Conversation
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
robustness-background-progress-request
branch
from
20ae650 to
6376ee0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #21546 +/- ##
==========================================
- Coverage 68.45% 68.40% -0.05%
==========================================
Files 428 428
Lines 35383 35383
==========================================
- Hits 24221 24204 -17
- Misses 9761 9772 +11
- Partials 1401 1407 +6 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henrybear327, nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| cancel() | ||
| } | ||
| } | ||
| case <-time.After(100 * time.Millisecond): |
There was a problem hiding this comment.
Nit: may consider making 100 as a const.
4 participants
/cc @henrybear327 @nwnt