Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c247dc5 to
f8ad38d
Compare
|
@henrybear327: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 2df9bfb to get more accurate results. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #21472 +/- ##
==========================================
- Coverage 68.47% 68.43% -0.04%
==========================================
Files 428 428
Lines 35291 35291
==========================================
- Hits 24165 24151 -14
- Misses 9730 9740 +10
- Partials 1396 1400 +4 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
f8ad38d to
ba49ac5
Compare
ba49ac5 to
f946ff2
Compare
0aee356 to
a5ebc34
Compare
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
Targeting bug fix etcd-io#20281 Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
a5ebc34 to
2df9bfb
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Targeting bug fix #20281
The idea is that we have a watch that was connected to a peer A, and have received event there. Due to cluster client switching the connection to a different peer, with the blackholeUntilSnapshot failpoint enabled, by chance it would connect to a peer that is blackholed and lags behind. In this case, due to the bug, we could get a revision that is in the past, as seen in the log.