Skip to content

robustness: 20221 reproduction#21472

Draft
henrybear327 wants to merge 2 commits intoetcd-io:mainfrom
henrybear327:robustness/20221_repro_bug_2
Draft

robustness: 20221 reproduction#21472
henrybear327 wants to merge 2 commits intoetcd-io:mainfrom
henrybear327:robustness/20221_repro_bug_2

Conversation

@henrybear327
Copy link
Copy Markdown
Contributor

Targeting bug fix #20281

The idea is that we have a watch that was connected to a peer A, and have received event there. Due to cluster client switching the connection to a different peer, with the blackholeUntilSnapshot failpoint enabled, by chance it would connect to a peer that is blackholed and lags behind. In this case, due to the bug, we could get a revision that is in the past, as seen in the log.

    logger.go:146: 2026-03-11T16:11:25.397Z     ERROR   Broke watch guarantee   {"guarantee": "resumable", "client": 20, "request": {"Key":"key","Revision":1593,"WithPrefix":true,"WithProgressNotify":true,"WithPrevKV":true}, "got-event": {"Type":"put-operation","Key":"key76","Value":{"Value":"1981"},"Revision":1571,"PrevValue":{"Value":{"Value":"1976"},"ModRevision":1567,"Version":23}}, "want-event": {"Type":"put-operation","Key":"key80","Value":{"Value":"2010"},"Revision":1593}}

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrybear327 henrybear327 changed the title [Robustness] 20221 reproduction robustness: 20221 reproduction Mar 11, 2026
@henrybear327 henrybear327 force-pushed the robustness/20221_repro_bug_2 branch from c247dc5 to f8ad38d Compare March 11, 2026 18:44
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 11, 2026

@henrybear327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 f8ad38d link true /test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.43%. Comparing base (50f4ea2) to head (f8ad38d).
⚠️ Report is 50 commits behind head on main.

⚠️ Current head f8ad38d differs from pull request most recent head 2df9bfb

Please upload reports for the commit 2df9bfb to get more accurate results.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21472      +/-   ##
==========================================
- Coverage   68.47%   68.43%   -0.04%     
==========================================
  Files         428      428              
  Lines       35291    35291              
==========================================
- Hits        24165    24151      -14     
- Misses       9730     9740      +10     
- Partials     1396     1400       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f4ea2...2df9bfb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrybear327 henrybear327 requested a review from serathius March 11, 2026 20:25
@henrybear327 henrybear327 self-assigned this Mar 11, 2026
@henrybear327 henrybear327 marked this pull request as draft March 12, 2026 15:13
@henrybear327 henrybear327 force-pushed the robustness/20221_repro_bug_2 branch from f8ad38d to ba49ac5 Compare March 15, 2026 20:48
@henrybear327 henrybear327 force-pushed the robustness/20221_repro_bug_2 branch from ba49ac5 to f946ff2 Compare March 16, 2026 21:51
@henrybear327 henrybear327 force-pushed the robustness/20221_repro_bug_2 branch 9 times, most recently from 0aee356 to a5ebc34 Compare March 17, 2026 14:53
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
Targeting bug fix etcd-io#20281

Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
@henrybear327 henrybear327 force-pushed the robustness/20221_repro_bug_2 branch from a5ebc34 to 2df9bfb Compare March 17, 2026 17:29
@k8s-ci-robot
Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants