raftexample: apply conf change entries before send message #15450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update raftexample to apply conf changes before send raft.Ready.Messages. Candidate or follower needs to wait for all pending conf changes. Otherwise there might be incorrectly count votes. This PR introduces the fix from etcd-io#7595 and pr num 7706. Signed-off-by: Kee-Hyun Kum <[email protected]> Signed-off-by: KumKeeHyun <[email protected]>
KumKeeHyun
force-pushed
the
raftexample-conf-before-send
branch
from
a367ea9 to
54b8b2b
Compare
|
cc @tbg |
|
FYI. #15471 (comment) |
|
Thanks @KumKeeHyun anyway. |
|
Thanks for reply :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update raftexample to apply conf changes before send raft.Ready.Messages. Candidate or follower needs to wait for all pending conf changes. Otherwise there might be incorrectly count votes.
This PR introduces the fix from #7595 and pr num 7706.
Same logic as etcdserver/raft.go at main
Since conf changes are applied directly in publishEntries, it doesn't need to wait for the applyDoneC.