Repository navigation
[release-1.3] cmd/bbolt: reject compacting a database onto itself - #1297
Merged
ahrtr merged 1 commit intoOct 14, 2026
Merged
Conversation
`bbolt compact -o data.db data.db` waits forever for a lock it already holds. Using a hard-link alias as the destination has the same result. Reject source and destination paths that refer to the same file before opening either database. Cherry-picked from etcd-io#1286 (e5042fb). Signed-off-by: Aditya <205600203+Rohilalala@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Elbehery The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Elbehery
added a commit
to Elbehery/bbolt
that referenced
this pull request
Oct 14, 2026
- Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1, v1.6.0 with entry
for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
- Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
- Create CHANGELOG-1.6.md for the upcoming v1.6.0 release
Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery
added a commit
to Elbehery/bbolt
that referenced
this pull request
Oct 14, 2026
- Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1, v1.6.0 with entry
for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
- Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
- Create CHANGELOG-1.6.md for the upcoming v1.6.0 release
Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery
added a commit
to Elbehery/bbolt
that referenced
this pull request
Oct 14, 2026
- Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1, v1.6.0 with entry
for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
- Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
- Create CHANGELOG-1.6.md for the upcoming v1.6.0 release
Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery
added a commit
to Elbehery/bbolt
that referenced
this pull request
Oct 14, 2026
- Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1 with entry
for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
- Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
- Create CHANGELOG-1.6.md for the upcoming v1.6.0 release
Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery
added a commit
to Elbehery/bbolt
that referenced
this pull request
Oct 14, 2026
- Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1 with entry
for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
- Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
- Create CHANGELOG-1.6.md for the upcoming v1.6.0 release
Signed-off-by: elbehery <elbeherymustafa@gmail.com>
ahrtr
pushed a commit
that referenced
this pull request
Oct 15, 2026
- Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1 with entry
for rejecting compact onto itself (PR #1297, #1296, #1295, #1286)
- Add sparc64 arch support entry (PR #1292, #1299) to v1.5.1 and v1.6.0
- Create CHANGELOG-1.6.md for the upcoming v1.6.0 release
Signed-off-by: elbehery <elbeherymustafa@gmail.com>
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bbolt compact -o data.db data.dbwaits forever for a lock it already holds. Using a hard-link alias as the destination has the same result.Reject source and destination paths that refer to the same file before opening either database.
Cherry-picked from #1286 (e5042fb).
cc @ahrtr