Skip to content

[release-1.3] cmd/bbolt: reject compacting a database onto itself - #1297

Merged
ahrtr merged 1 commit into
etcd-io:release-1.3from
Elbehery:14102026_cherry-pick-1286-to-release-1.3
Oct 14, 2026
Merged

ahrtr merged 1 commit into
etcd-io:release-1.3from
Elbehery:14102026_cherry-pick-1286-to-release-1.3

Conversation

@Elbehery

Copy link
Copy Markdown
Member

bbolt compact -o data.db data.db waits forever for a lock it already holds. Using a hard-link alias as the destination has the same result.

Reject source and destination paths that refer to the same file before opening either database.

Cherry-picked from #1286 (e5042fb).

cc @ahrtr

`bbolt compact -o data.db data.db` waits forever for a lock it already holds.
Using a hard-link alias as the destination has the same result.

Reject source and destination paths that refer to the same file before
opening either database.

Cherry-picked from etcd-io#1286 (e5042fb).
Signed-off-by: Aditya <205600203+Rohilalala@users.noreply.github.com>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery Elbehery changed the title cmd/bbolt: reject compacting a database onto itself [Release-1.3] cmd/bbolt: reject compacting a database onto itself Oct 14, 2026
@Elbehery Elbehery changed the title [Release-1.3] cmd/bbolt: reject compacting a database onto itself [release-1.3] cmd/bbolt: reject compacting a database onto itself Oct 14, 2026
Elbehery added a commit to Elbehery/bbolt that referenced this pull request Oct 14, 2026
  - Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1, v1.6.0 with entry
    for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
  - Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
  - Create CHANGELOG-1.6.md for the upcoming v1.6.0 release

  Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery added a commit to Elbehery/bbolt that referenced this pull request Oct 14, 2026
  - Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1, v1.6.0 with entry
    for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
  - Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
  - Create CHANGELOG-1.6.md for the upcoming v1.6.0 release

  Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery added a commit to Elbehery/bbolt that referenced this pull request Oct 14, 2026
  - Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1, v1.6.0 with entry
    for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
  - Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
  - Create CHANGELOG-1.6.md for the upcoming v1.6.0 release

Signed-off-by: elbehery <elbeherymustafa@gmail.com>
@ahrtr
ahrtr merged commit fd592ea into etcd-io:release-1.3 Oct 14, 2026
41 of 42 checks passed
Elbehery added a commit to Elbehery/bbolt that referenced this pull request Oct 14, 2026
  - Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1  with entry
    for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
  - Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
  - Create CHANGELOG-1.6.md for the upcoming v1.6.0 release

Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Elbehery added a commit to Elbehery/bbolt that referenced this pull request Oct 14, 2026
  - Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1  with entry
    for rejecting compact onto itself (PR etcd-io#1297, etcd-io#1296, etcd-io#1295, etcd-io#1286)
  - Add sparc64 arch support entry (PR etcd-io#1292, etcd-io#1299) to v1.5.1 and v1.6.0
  - Create CHANGELOG-1.6.md for the upcoming v1.6.0 release

Signed-off-by: elbehery <elbeherymustafa@gmail.com>
ahrtr pushed a commit that referenced this pull request Oct 15, 2026
  - Add `### CMD` section to v1.3.13, v1.4.4, v1.5.1  with entry
    for rejecting compact onto itself (PR #1297, #1296, #1295, #1286)
  - Add sparc64 arch support entry (PR #1292, #1299) to v1.5.1 and v1.6.0
  - Create CHANGELOG-1.6.md for the upcoming v1.6.0 release

Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants