Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE!: This PR only shows rework and differences from v1 #37

Draft
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

tomassebestik
Copy link
Member

DO NOT MERGE - THIS WILL BE BREAKING CHANGE 🚨

Refactor of v1

Jira Sync action is running in almost all GH repositories on lot every issue, PR, comment - performance improvement will have impact

  • clean up old codebase, lot of dead code, lot of hacky blocks
  • write proper tests - pytest / mock
  • now if PR / Issue is created by org member, it will not sync (intentionally) - review why
  • now we sync issue on issue_create, but PRs on schedule - review why not like issues
  • implement labels detection, that prevent sync
  • implement labels detection, handlig dependabot
  • simplify manual action (there is only one choice what to sync) or expand for more options)
  • simplify callers workflow

To decide

  • ❓ allow this action to be used outside of Espressif?

Related

  • internal Jira ticket RDT-930: Refactor code of GH Action for Jira Sync

Testing

@tomassebestik tomassebestik added the breaking-change 💥 A change that changes the API or breaks backward compatibility for users. label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello tomassebestik, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ac430b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change 💥 A change that changes the API or breaks backward compatibility for users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant