[Xtensa] fix duplicated CPI symbols with text section literals (LLVM-443)

[yamt]

Description

see #112

Related

Testing

Checklist

[andreisfr]

@yamt , thank you very much for a fix.

[yamt]

@andreisfr

@yamt , thank you very much for a fix.

have you merged it and reverted it? i couldn't find it on any branches.
i'm not familiar with branch policies in this repo.

[andreisfr]

@andreisfr

@yamt , thank you very much for a fix.

have you merged it and reverted it? i couldn't find it on any branches. i'm not familiar with branch policies in this repo.

@yamt, I created internal MR to the release_19..1.2 with your changes. This changes will be included in next update of the xtensa_release_19.1.2 branch.

[yamt]

@andreisfr

@yamt , thank you very much for a fix.

have you merged it and reverted it? i couldn't find it on any branches. i'm not familiar with branch policies in this repo.

@yamt, I created internal MR to the release_19..1.2 with your changes. This changes will be included in next update of the xtensa_release_19.1.2 branch.

• what's MR?

• is it appropriate to file PRs against xtensa_release_19.1.2 like this PR? i happened to fix an assertion failure on the branch today and i want to submit it.

[yamt]

• is it appropriate to file PRs against xtensa_release_19.1.2 like this PR? i happened to fix an assertion failure on the branch today and i want to submit it.

#114

[gerekon]

is it appropriate to file PRs against xtensa_release_19.1.2 like this PR? i happened to fix an assertion failure on the branch today and i want to submit it.

@yamt Yes, this is the proper way. We pick up PRs to our GL repo and after merging changes appear on GH.

BTW, we are going to switch dev branch to LLVM 20 (xtensa_release_20.1.1). Do you still need #114 on xtensa_release_19.1.2?

[yamt]

is it appropriate to file PRs against xtensa_release_19.1.2 like this PR? i happened to fix an assertion failure on the branch today and i want to submit it.

@yamt Yes, this is the proper way. We pick up PRs to our GL repo and after merging changes appear on GH.

ok. thank you.

BTW, we are going to switch dev branch to LLVM 20 (xtensa_release_20.1.1). Do you still need #114 on xtensa_release_19.1.2?

i explained my situation here: #112 (comment)
probably llvm 20 is ok. i don't know for sure because i haven't tried yet though.

[gerekon]

@yamt Added commit to xtensa_release_19.1.2 too.