Improved tools checksums (EIM-109) #48
Conversation
Hahihula
commented
Feb 4, 2025
Hahihula
commented
Hahihula
force-pushed
the
EIM-109-improved-sha-verifgication
branch
from
6648dd5 to
e69a175
Compare
|
When i tested using the expert setup it hangs on IDF Cmake when using dl.espressif.cn mirror:
The setup fails to check prerequisites in MacOS M1 (ninja, cmake dfu-util). |
| @@ -31,6 +31,7 @@ | |||
| <tr data-id="tools-table-header"> | |||
| <th>Tool</th> | |||
| <th>Downloaded</th> | |||
| <th>SHA</th> | |||
There was a problem hiding this comment.
SHA is used internally to verify the downloaded file. Do we really need to show this to the user?
There was a problem hiding this comment.
how do you suggest informing the user when the checksum verification fails after we removed the popup messages?
There was a problem hiding this comment.
We could consider combining the “Downloaded” status with “SHA” verification for a more concise status update. If the file is downloaded but does not match the checksum, we can mark it as an invalid file and display an error flag.
Exposing too many internal details with different labels might unnecessarily complicate the UI, especially when the user cannot take any specific action based on them.
Think about it.
