Skip to content

Conversation

@suda-morris
Copy link
Contributor

After espressif/esp-idf@08b7552 The SPI LCD IO driver can detect the "quad" mode automatically, there's no need to set it explicitly.

Closes espressif/esp-idf#17455 as well

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello suda-morris, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1bfffc5

@github-actions github-actions bot changed the title fix(sh8601): work again with idf v6.0 fix(sh8601): work again with idf v6.0 (AEGHB-1209) Sep 8, 2025
Copy link
Contributor

@Lzw655 Lzw655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating! LGTM!

@suda-morris suda-morris force-pushed the bugfix/sh8601_init_fix branch from 039a6e2 to 1bfffc5 Compare September 9, 2025 02:34
@leeebo leeebo self-requested a review September 9, 2025 03:09
@leeebo
Copy link
Collaborator

leeebo commented Sep 9, 2025

sha=1bfffc54d429517c96f1dd6ce2afc107a62ec3cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

esp-idf 6.0版本在编译lvgl项目时屏幕显示不正常 (IDFGH-16307)

4 participants