Skip to content

feat: Switch to the custom chat bot feature and improve the suggestions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dobairoland
Copy link
Collaborator

No description provided.

@dobairoland dobairoland force-pushed the feat/switch_to_custom_chat branch from 0310bc8 to 059ecec Compare March 13, 2025 16:55
@dobairoland dobairoland requested a review from Copilot March 13, 2025 16:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the chatbot to a custom implementation while expanding its configuration options and enhancing suggestion behavior.

  • Added new input configurations for bot behavior and revised instructions in action.yml.
  • Updated the bot_action.py to support multiple arguments and compose a structured payload for the custom chat bot.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
action.yml Added new inputs for bot behavior and updated instructions.
bot_action/bot_action.py Revised the function signature and payload structure to support the custom chat bot.

@dobairoland dobairoland force-pushed the feat/switch_to_custom_chat branch 5 times, most recently from 2ed66c1 to 702124d Compare March 13, 2025 17:56
@dobairoland dobairoland marked this pull request as ready for review March 14, 2025 11:24
@dobairoland dobairoland force-pushed the feat/switch_to_custom_chat branch 4 times, most recently from 5fdc9fa to 631d8e6 Compare March 14, 2025 13:22
@dobairoland
Copy link
Collaborator Author

dobairoland commented Mar 14, 2025

  • The funny thing about "custom chat" is that it always signs the letter. If you don't provide a name then leaves just "Best regards, [Your Name]". I've tried to tell it to not sign it or don't use e-mail template. It didn't work.
  • It looks that the query is limited to 15k characters for all kinds of chats. So this won't solve Bot fails with tracing output from esptool (IDFGH-14816) #9.

I will probably close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant