Skip to content

feat(docs): Add Zigbee library API documentation #11525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This pull request adds documentation for new Zigbee library, expanding the API coverage.

  • Added Zigbee APIs to Table of Contents: Included a new section in libraries.rst that organizes Zigbee-related APIs under their own subsection, improving navigation and discoverability.

Tests scenarios

Related links

Closes #10135

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jun 27, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y requested review from pedrominatel and a team as code owners June 27, 2025 12:03
@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Jun 27, 2025
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Messages
📖 This PR seems to be quite large (total lines of code: 4186), you might consider splitting it into smaller PRs

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c00305c

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request May 16, 2025
17 tasks
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as draft June 27, 2025 12:10
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as ready for review June 27, 2025 12:18
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review Area: Zigbee Issues and Feature Request about Zigbee labels Jun 27, 2025
@pedrominatel
Copy link
Member

Thank you very much for your contribution, @P-R-O-C-H-Y. It will take some time, but I'll review ASAP.

Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some leftover python and temp files

Copilot

This comment was marked as outdated.

@P-R-O-C-H-Y
Copy link
Member Author

I think there are some leftover python and temp files

@lucasssvaz Removed, thanks :)

@lucasssvaz lucasssvaz requested a review from Copilot July 7, 2025 18:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive Zigbee library API documentation by introducing new RST files for core and endpoint classes and updating the main libraries index.

  • Added ZigbeeEP endpoint base class documentation with detailed API breakdown.
  • Added ZigbeeCore main class documentation covering network management and utilities.
  • Created individual endpoint docs (ep_*) for each Zigbee device type and updated libraries.rst TOC.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/en/zigbee/zigbee_ep.rst Added base endpoint API reference
docs/en/zigbee/zigbee_core.rst Added core library API reference
docs/en/zigbee/zigbee.rst Added overview, topology, and toctree
docs/en/zigbee/ep_*.rst Added specific endpoint class docs
docs/en/libraries.rst Updated Table of Contents with Zigbee
Comments suppressed due to low confidence (2)

docs/en/zigbee/zigbee_ep.rst:346

  • [nitpick] The description for the callback parameter 'time' is listed under the method instead of alongside the callback signature; consider clarifying its placement under the callback details.
* ``time`` - Identify time in seconds

docs/en/zigbee/ep_door_window_handle.rst:95

  • The example section is marked 'To be added'. Please provide a concrete example or remove the placeholder.
*To be added*

Comment on lines +46 to +47
* **Router**: Extends network range, routes messages, mains powered devices (typicaly lights, switches, etc.)
* **End Device**: Battery-powered devices that can sleep for extended periods (typicaly sensors)
Copy link
Preview

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistake: 'typicaly' should be 'typically'.

Suggested change
* **Router**: Extends network range, routes messages, mains powered devices (typicaly lights, switches, etc.)
* **End Device**: Battery-powered devices that can sleep for extended periods (typicaly sensors)
* **Router**: Extends network range, routes messages, mains powered devices (typically lights, switches, etc.)
* **End Device**: Battery-powered devices that can sleep for extended periods (typically sensors)

Copilot uses AI. Check for mistakes.

Comment on lines +46 to +47
* **Router**: Extends network range, routes messages, mains powered devices (typicaly lights, switches, etc.)
* **End Device**: Battery-powered devices that can sleep for extended periods (typicaly sensors)
Copy link
Preview

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistake: 'typicaly' should be 'typically'.

Suggested change
* **Router**: Extends network range, routes messages, mains powered devices (typicaly lights, switches, etc.)
* **End Device**: Battery-powered devices that can sleep for extended periods (typicaly sensors)
* **Router**: Extends network range, routes messages, mains powered devices (typically lights, switches, etc.)
* **End Device**: Battery-powered devices that can sleep for extended periods (typically sensors)

Copilot uses AI. Check for mistakes.

**********

For better debugging, you can enable debug mode to get detailed information about network operations. Call debug mode before starting Zigbee.
Also selectiong zigbee mode with *debug* suffix is recommended.
Copy link
Preview

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistake: 'selectiong' should be 'selecting'.

Suggested change
Also selectiong zigbee mode with *debug* suffix is recommended.
Also selecting zigbee mode with *debug* suffix is recommended.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Review needed Issue or PR is awaiting review Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Zigbee in Arduino
3 participants