-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(codeowners): Initial CODEOWNERS setup #11397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@me-no-dev @SuGlider @P-R-O-C-H-Y @pedrominatel PTAL and see if you would like to change/add/remove something. @rftafas @igrr @Parsaabasi Would you like to be code owners of any specific files ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucasssvaz, I agree.
.github/CODEOWNERS
Outdated
|
||
# The CODEOWNERS file should be owned by the developers of the ESP32 Arduino Core. | ||
# Leave this entry as the last one to avoid being overridden. | ||
/.github/CODEOWNERS @lucasssvaz @me-no-dev @P-R-O-C-H-Y @SuGlider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding espressif/admins here, just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it needs to be public to be a code owner:
Unknown owner on line 70: make sure the team @espressif/admins exists, is publicly visible, and has write access to the repository
* @lucasssvaz @me-no-dev @P-R-O-C-H-Y @SuGlider | ||
|
||
# CI | ||
/.github/ @lucasssvaz @me-no-dev @P-R-O-C-H-Y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and optionally espressif/ci here, just in case some workflow has to be updated due to a security issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change our CI files quite frequently. Wouldn't this spam the CI team with review notifications? I have never used CODEOWNERS
before so I don't know. The idea is to enable the branch protection rule to require codeowners review and AFAIK this automatically requests the review of all owners.
This pull request introduces a new
CODEOWNERS
file to the repository, specifying ownership rules for different parts of the ESP32 Arduino Core project. The file ensures that review requests are directed to the appropriate developers based on the file or directory being modified.Other libraries and files can be added with time. This is only the initial setup.