feat(matter): adds new Matter Endpoint: Color Light #10647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 61 files 61 suites 5m 47s ⏱️ Results for commit 916e949. ♻️ This comment has been updated with latest results. |
|
@P-R-O-C-H-Y will the color formats be usable within Zigbee also? |
…essif#10640) Co-authored-by: NPaolini <[email protected]>
@SuGlider @me-no-dev Yes, I am using the XYtoRGB and RGBtoXY also. So that part of code is duplicated :) |
|
I'd say to put it in the core. It can be used for our own color led too. Only suggestion is to maybe prefix the function names, so that they do not clash with libraries that possibly have them as well |
We can add a namespace to it. |
|
No namespace please: https://stackoverflow.com/questions/46626494/does-c-have-namespaces-similar-to-c |
* feat(asyncudp): add all current keywords to the list * feat(asyncudp): add license information to the source code * feat(asyncudp): add license information to the source code * feat(asyncudp): add license information to the source code * feat(asyncudp): add license information to the source code * feat(asyncudp): add license information to the source code * feat(asyncudp): revert license information to the source code * feat(asyncudp): revert license information to the source code * feat(asyncudp): revert license information to the source code * feat(asyncudp): revert license information to the source code * feat(asyncudp): revert license information to the source code * ci(pre-commit): Apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a new Matter Endpoint: MatterColorLight.
It has also an example.
Tests scenarios
ESP32-S3 with the provided example.
Related links
Related to #7432