Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start/stop VA services #272

Closed
wants to merge 3 commits into from
Closed

Add start/stop VA services #272

wants to merge 3 commits into from

Conversation

tetele
Copy link
Contributor

@tetele tetele commented Jan 5, 2025

This would enable users to automate triggering the VA pipeline externally, from HA. A few usecases:

  • starting the VA when your face gets recognized by CompreFace
  • pressing a button
  • adding sentence triggers in automations to create conversations
  • etc.

@andreasbrett
Copy link

I think this would benefit from checking if VA is already running and if the mute switch is turned off before starting VA (basically the conditions from the button click action).

Add checks and extra actions when starting the VA
@tetele
Copy link
Contributor Author

tetele commented Jan 9, 2025

@andreasbrett great idea! Thanks and done!

@jlpouffier
Copy link
Contributor

I would propose to wait until this architecture discussion is built.
We're working on it as we speak: home-assistant/architecture#1143

The Assist Satellite entity will support starting a conversation natively.

I do not want to introduce something we know will be removed in the near future.

However I do agree with the need to start a pipeline remotely, but let's do it cleanly from the get-go

@tetele
Copy link
Contributor Author

tetele commented Jan 13, 2025

Historically, voice stuff and "near future" never went hand in hand. Also, I don't see any issue with making these service backwards compatible (e.g. by calling assist_satellite.start_conversation from the ESP side, albeit less efficiently), but I guess OK.

@balloob
Copy link
Member

balloob commented Jan 13, 2025

I agree with JLo, we're working on doing this a standardized way and we shouldn't complicate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants