-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send hello and login asynchronously to speed up connecting #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 77.93% 78.49% +0.55%
==========================================
Files 14 14
Lines 2493 2511 +18
==========================================
+ Hits 1943 1971 +28
+ Misses 550 540 -10
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Looks like we have no coverage for wrong password |
Manually test with wrong encryption key as well to make sure it doesn't cause a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current we send HelloRequest, wait for a response, than send ConnectRequest and wait for a response.
We can send the
HelloRequest
andConnectRequest
, and than wait for both responses instead as it reduces one round trip wait.This should speed up connecting with encryption enabled a little bit since it reported to be slow in home-assistant/core#103517 (comment)