Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small readability improvements to the plain_text frame helper #626

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 9, 2023

Move the rare failure case into a new function

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #626 (717064d) into main (94157a8) will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   77.87%   77.92%   +0.05%     
==========================================
  Files          14       14              
  Lines        2490     2492       +2     
==========================================
+ Hits         1939     1942       +3     
+ Misses        551      550       -1     
Files Coverage Δ
aioesphomeapi/_frame_helper/plain_text.py 95.74% <83.33%> (+1.17%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@bdraco bdraco merged commit 419bf67 into main Nov 9, 2023
10 checks passed
@bdraco bdraco deleted the split_plaintext branch November 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant