Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging on clean disconnect failure #609

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 1, 2023

  • Use the name of the request type that was sent instead of the raw class as its more readable
  • Adds some more missing coverage

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #609 (60f4c15) into main (5a85c01) will increase coverage by 0.67%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   76.05%   76.72%   +0.67%     
==========================================
  Files          14       14              
  Lines        2485     2488       +3     
==========================================
+ Hits         1890     1909      +19     
+ Misses        595      579      -16     
Files Coverage Δ
aioesphomeapi/connection.py 81.47% <100.00%> (+3.72%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdraco bdraco merged commit 1d2682a into main Nov 1, 2023
10 checks passed
@bdraco bdraco deleted the disconnect_failure branch November 1, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant