Fix CIBW_SKIP for musllinux in the release workflow #1032
Conversation
The check should have been for musllinux instead of musl
CodSpeed Performance ReportMerging #1032 will not alter performanceComparing Summary
|
WalkthroughThe pull request modifies the GitHub Actions release workflow configuration, specifically adjusting the Changes
Sequence DiagramsequenceDiagram
participant Workflow as GitHub Actions Workflow
participant Builder as Wheel Builder
Workflow->>Builder: Trigger wheel build
Builder->>Builder: Evaluate CIBW_SKIP conditions
alt Skip based on musllinux
Builder->>Workflow: Skip specific wheel configurations
else Build wheels
Builder->>Workflow: Generate wheels
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
Line range hint
15-22: Consider renaming the matrix variable for clarity.The matrix variable
muslcould be renamed tolinux_variantorplatform_variantsince it specifically distinguishes between standard Linux (empty string) and musllinux builds. This would make the configuration more self-documenting.strategy: matrix: os: [ubuntu-24.04-arm, ubuntu-latest, macos-13, macos-latest] - musl: ["", "musllinux"] + linux_variant: ["", "musllinux"] exclude: - os: macos-13 - musl: "musllinux" + linux_variant: "musllinux" - os: macos-latest - musl: "musllinux" + linux_variant: "musllinux"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: py 3.13 on ubuntu-latest (use_cython)
- GitHub Check: py 3.9 on ubuntu-latest (use_cython)
- GitHub Check: Run benchmarks
🔇 Additional comments (2)
.github/workflows/release.yml (2)
Line range hint
1-83: The workflow configuration follows security best practices.Notable security and best practices implementations:
- Minimal permissions using
contents: read- Trusted actions with pinned versions
- Proper environment isolation for PyPI publishing
- Secure PyPI publishing using OIDC token (
id-token: write)
36-36: LGTM! Verify the wheel build outputs.The condition update from
musltomusllinuxcorrectly aligns with the matrix configuration. This should properly control the wheel building process by skipping manylinux wheels for musllinux builds and vice versa.Let's verify the impact on wheel building by checking recent workflow runs:
✅ Verification successful
Verified: CIBW_SKIP configuration is correct and properly configured
The wheel building setup is properly configured:
- Matrix values correctly define musl="" for manylinux and musl="musllinux" for musl builds
- CIBW_SKIP condition matches these matrix values exactly
- Proper exclusions prevent musllinux builds on macOS
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check recent workflow runs to verify wheel building behavior # Expected: Should see different wheel types being built/skipped based on the linux_variant gh run list --workflow=release.yml --limit 2 --json conclusion,databaseId | \ jq -r '.[].databaseId' | \ while read -r run_id; do echo "Checking run $run_id" gh run view "$run_id" --log | grep -A 5 "cibuildwheel: Building wheels for" doneLength of output: 429
Script:
#!/bin/bash # Check workflow configuration and cibuildwheel setup echo "=== Workflow Configuration ===" cat .github/workflows/release.yml echo -e "\n=== Searching for cibuildwheel config ===" fd -e toml -e ini -e cfg -e conf . | xargs grep -l -i "cibuildwheel\|CIBW" || true echo -e "\n=== Searching for CIBW environment variables ===" rg "CIBW_" -A 2 -B 2Length of output: 2343
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2681 2681
=========================================
Hits 2681 2681 ☔ View full report in Codecov by Sentry. |
The check should have been for musllinux instead of musl