Reworking of verbose-form-template package #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I liked what the package could do, but followingn an initial dialogue with the author. we were still left with various issues in the original PR https://github.com/espanso/hub/pull/85/files#diff-e9a373201f8cc15904a47996833a6560bd9c676535441158e0cf832b61f2f309 I decided to rework it and have: - removed the original package whose name was prefixed with 'espanso-' - rewritten `README.md` to replace the emphasis on `choice` in favour of `list` - removed the image from the package - updated `_manifest.yml` with corrected `name:`, `homepage:`, `title:`, and added my name as a contributor (hope that's OK!) - reformatted `package.yml` to make it more readable, shortened the trigger, and reformatted the form so it displays better and is easier to use. I submitted a PR to the author's repo three months ago, but no response, so it's time to submit it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I liked what the original package could do, but following an initial dialogue with the author, we were still left with various issues in the original PR https://github.com/espanso/hub/pull/85/files#diff-e9a373201f8cc15904a47996833a6560bd9c676535441158e0cf832b61f2f309
I decided to rework it and:
README.mdto replace the emphasis onchoicein favour oflist_manifest.ymlwith correctedname:,homepage:,title:, and added my name as a contributorpackage.ymlto make it more readable, shortened the trigger, and reformatted the form so it displays better and is easier to use.I submitted a PR to the author's repo three months ago, but no response, so it's time to submit it directly.