-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LLM Prompts package #156
Conversation
Thank you. I've only had a quick look, but it needs a version number in the file path, to match that in I'll run the CI and have a closer look later. |
No shell, script or potentially malicious code. The CI is all fine apart from the required version number in the path, as mentioned above. Have a look at existing packages to see what I mean. Would you kindly change the "prompts" tag to "prompt", to match the other AI package, please? Once all these are done, I'll go ahead and merge. |
Thanks a lot for the feedback. I will make the requested changes tomorrow
Stephen Meech ***@***.***> schrieb am Fr. 7. März 2025 um
11:32:
… No shell, script or potentially malicious code.
The CI is all fine apart from the required version number in the path, as
mentioned above. Have a look at existing packages to see what I mean.
Would you kindly change the "prompts" tag to "prompt", to match the other
AI package <https://hub.espanso.org/oasis-is-framework>, please?
Once all these are done, I'll go ahead and merge.
—
Reply to this email directly, view it on GitHub
<#156 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAE4F64BSHMZ5OTRSRUGWT2TFYTRAVCNFSM6AAAAABYPWDLLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBWGA4TQNZRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: smeech]*smeech* left a comment (espanso/hub#156)
<#156 (comment)>
No shell, script or potentially malicious code.
The CI is all fine apart from the required version number in the path, as
mentioned above. Have a look at existing packages to see what I mean.
Would you kindly change the "prompts" tag to "prompt", to match the other
AI package <https://hub.espanso.org/oasis-is-framework>, please?
Once all these are done, I'll go ahead and merge.
—
Reply to this email directly, view it on GitHub
<#156 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAE4F64BSHMZ5OTRSRUGWT2TFYTRAVCNFSM6AAAAABYPWDLLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBWGA4TQNZRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
- Used "prompt" instead of "prompts" to match other available package - added new "GenAI" tag
I think I applied all required changes. Could you please take a look? |
I'm removing "Or manually by cloning this repository into your Espanso packages directory." from README.md. In my experience, manually adding packages can break the `espanso package (un)install` command.
I have removed "Or manually by cloning this repository into your Espanso packages directory." from the README.md, as manually installing packages can break the |
The pr-quality-check is failing with:
It looks fine to me, and certainly works. We have a few courses of action:
I'll try 1. |
Well, that seems to have broken things, as the CI now chokes on the unquoted values in the package. I may need to revert the merge, and see what @arabello thinks. |
I have wrapped all triggers in quotes now, can you try again, please? |
I'm not seeing the changes here, and Reverting the last PR has left the files in the repo. Unless you have a better suggestion, perhaps submit a new PR, updating the version to, say, |
I created #160 (but keep version the same). Does that work or do I need to update the version as well? |
I'll try it, and see if it over-writes the previous version - it should - I don't understand why Federico wanted previous versions preserved. |
a package with helpful prompts for LLMs acting as a prompt library for Espanso users.