Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LLM Prompts package #156

Merged
merged 7 commits into from
Mar 8, 2025
Merged

add LLM Prompts package #156

merged 7 commits into from
Mar 8, 2025

Conversation

mmarschall
Copy link
Contributor

a package with helpful prompts for LLMs acting as a prompt library for Espanso users.

@smeech
Copy link
Collaborator

smeech commented Mar 6, 2025

Thank you.

I've only had a quick look, but it needs a version number in the file path, to match that in _manifest.yml, and the latter could do with a homepage: value, even if it's only https://github.com/mmarschall/espanso-hub/tree/main, please.

I'll run the CI and have a closer look later.

@smeech
Copy link
Collaborator

smeech commented Mar 7, 2025

No shell, script or potentially malicious code.

The CI is all fine apart from the required version number in the path, as mentioned above. Have a look at existing packages to see what I mean.

Would you kindly change the "prompts" tag to "prompt", to match the other AI package, please?

Once all these are done, I'll go ahead and merge.

@mmarschall
Copy link
Contributor Author

mmarschall commented Mar 7, 2025 via email

- Used "prompt" instead of "prompts" to match other available package
- added new "GenAI" tag
@mmarschall
Copy link
Contributor Author

I think I applied all required changes. Could you please take a look?

I'm removing "Or manually by cloning this repository into your Espanso packages directory." from README.md.

In my experience, manually adding packages can break the `espanso package (un)install` command.
@smeech
Copy link
Collaborator

smeech commented Mar 8, 2025

I have removed "Or manually by cloning this repository into your Espanso packages directory." from the README.md, as manually installing packages can break the espanso (un)install command.

@smeech
Copy link
Collaborator

smeech commented Mar 8, 2025

The pr-quality-check is failing with:

Check: invalid_yaml
 ->: invalid YAML detected in file: packages/llm-prompts/0.1.0/package.yml, please make sure the file is formatted correctly. If you're unsure of the error, you can use http://www.yamllint.com/ to validate it.
Error: while parsing a flow node
expected the node content, but found ':'
  in "packages/llm-prompts/0.1.0/package.yml", line 3, column 15

It looks fine to me, and certainly works.

We have a few courses of action:

  1. Go ahead and merge anyway and see if the Hub picks it up
  2. Await intervention from @arabello, who is one of the few people who understands these things, but isn't often about
  3. Reformat package.yml so that all the triggers: values are quoted.

I'll try 1.

@smeech smeech merged commit 026b19f into espanso:main Mar 8, 2025
1 check failed
@smeech
Copy link
Collaborator

smeech commented Mar 9, 2025

Well, that seems to have broken things, as the CI now chokes on the unquoted values in the package. I may need to revert the merge, and see what @arabello thinks.
If you're in a hurry to have the package accepted, you could add quotes to the triggers: [values], although your syntax is entirely acceptable to Espanso itself.

@mmarschall
Copy link
Contributor Author

mmarschall commented Mar 9, 2025

I have wrapped all triggers in quotes now, can you try again, please?

@smeech
Copy link
Collaborator

smeech commented Mar 9, 2025

I have wrapped all triggers in quotes now, can you try again, please?

I'm not seeing the changes here, and Reverting the last PR has left the files in the repo. Unless you have a better suggestion, perhaps submit a new PR, updating the version to, say, 0.1.1 in the file paths and _manifest.yml, and we'll try again.

@mmarschall
Copy link
Contributor Author

I created #160 (but keep version the same). Does that work or do I need to update the version as well?

@smeech
Copy link
Collaborator

smeech commented Mar 9, 2025

I created #160 (but keep version the same). Does that work or do I need to update the version as well?

I'll try it, and see if it over-writes the previous version - it should - I don't understand why Federico wanted previous versions preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants