Skip to content

ci: Test in Bun#87

Merged
mdjermanovic merged 2 commits intomainfrom
bun-test
Jun 4, 2025
Merged

ci: Test in Bun#87
mdjermanovic merged 2 commits intomainfrom
bun-test

Conversation

@nzakas
Copy link
Copy Markdown
Member

@nzakas nzakas commented Jul 12, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add Bun CI testing

What changes did you make? (Give an overview)

  • Added GitHub workflow to run Bun
  • Made a small modification to a test in config-array because Bun has a different error message than in Node.js

Related Issues

Is there anything you'd like reviewers to focus on?

@nzakas
Copy link
Copy Markdown
Member Author

nzakas commented Jul 12, 2024

Not sure what's going on here. I can do bun run --bun build locally (Windows) and it works but seems to be failing in the CI.

@amareshsm
Copy link
Copy Markdown
Member

Not sure what's going on here. I can do bun run --bun build locally (Windows) and it works but seems to be failing in the CI.

In macOS, executing the bun run --bun build command within individual packages works correctly, but running it from the root directory results in the following error.
image

@nzakas
Copy link
Copy Markdown
Member Author

nzakas commented Jul 15, 2024

@amareshsm can you file a bug for Bun given that you can reproduce the problem locally?

@amareshsm
Copy link
Copy Markdown
Member

@amareshsm can you file a bug for Bun given that you can reproduce the problem locally?

Done.

@nzakas
Copy link
Copy Markdown
Member Author

nzakas commented Sep 3, 2024

Waiting for resolution on oven-sh/bun#12574

@kecrily
Copy link
Copy Markdown
Member

kecrily commented Jun 4, 2025

After I rebase this branch to main, build doesn't report any more errors. We can move forward now.

@nzakas
Copy link
Copy Markdown
Member Author

nzakas commented Jun 4, 2025

Thanks for the heads up. I'll rebase and see what happens.

@nzakas
Copy link
Copy Markdown
Member Author

nzakas commented Jun 4, 2025

Okay, everything is in the green! 🎉 I just need an approval to merge.

Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit b8bf819 into main Jun 4, 2025
21 checks passed
@mdjermanovic mdjermanovic deleted the bun-test branch June 4, 2025 18:48
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 4, 2025
snitin315 pushed a commit that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants