ci: use pnpm/action-setup for pnpm #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
The
pnpm-installjob in the workflow .github/workflows/ci-build-all-pm.yml relies on a version of Corepack bundled with Node.js. The Node.js website https://nodejs.org/docs/latest/api/corepack.html states "... Corepack itself will no longer be distributed with future versions of Node.js." which would cause the workflow to break.Following the pnpm package manager's documentation Continuous Integration > GitHub Actions, the installation method for pnpm in GitHub Actions is changed to using the JavaScript GitHub Action pnpm/action-setup@v4, replacing the need for Corepack.
What changes did you make? (Give an overview)
In the workflow .github/workflows/ci-build-all-pm.yml
pnpm-installjob, replacecorepackwith pnpm/action-setup@v4 following the example in Continuous Integration > GitHub Actions.Related Issues
Is there anything you'd like reviewers to focus on?
Check that https://github.com/eslint/css/actions/workflows/ci-build-all-pm.yml completes successfully