Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Initial kotlin support fixes #453 #532

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Initial kotlin support fixes #453 #532

wants to merge 8 commits into from

Conversation

yveszoundi
Copy link
Contributor

This brings initial kotlin support into eclim to fix #453.

Please review, especially the vim part (copy/paste/modify from the groovy support).

I didn't really have time to add unit tests, but I think it's "decent" for a quick attempt and mirrors as closely as possible existing eclim practices.

@ervandew
Copy link
Owner

First, thank you for taking the time to add kotlin support. My only conundrum is that I'm finding myself with less and less time to devote to eclim (this is a one man show, and since moving away from the city, I want to spend my free time outside, not in front of the computer), and contributions like this, while awesome, inevitably leave me with more code to maintain, which can be compounded by the fact that I didn't write the original code. Adding unit tests would certainly help, so I can at least make sure that from release to release that the code you wrote still works, but ultimately I think i would prefer to start working towards having eclim plugins live in other repositories, that way their authors can have free reign to add features, fix bugs, etc without waiting on me, and I can defer bugs/issues to the authors.

So, I will say that I'm probably not going to merge this in, and instead I'd prefer to spend that time working on a way to support installing eclim plugins from other repositories (I want to replace the existing installer with a simple non-UI version). I plan to move some of the existing eclim plugins that I personally don't use, and which can take time to maintain, out to separate repositories as well (adt, cdt, dltkruby, groovy, pdt, sdt). I'm open to ideas on how best to do this, should you have any ideas, concerns, etc.

@yveszoundi
Copy link
Contributor Author

Hi Eric,

First, thanks for taking the time to answer.

I fully understand and I've been there before. I, for myself, have stopped maintaining any medium/large open source projects a long time ago. Many people don't understand what it takes to keep a non-hello world project alive and maintain a decent level of quality for years.

I think that it's a good idea to move non-core plugins out of "Eclim" core. That would allow more people to decide how/when to contribute and assume ownership of their work. It could also lower any barrier understanding the build infrastructure.

I think that it's worth creating a "discussion ticket", to see how users feel about it. Maybe they can also help with the ground work.

Take care

@jamesdbowman
Copy link

What's the latest here regarding Kotlin support? If I'm interested in helping, how can I best contribute?

@yveszoundi
Copy link
Contributor Author

@jamesdbowman , I had "decent enough" initial implementation. Per comments from Eric in this issue, there's not much hope for Kotlin support, at least in this repository.

You could probably pickup my outdated diffs in this pull request and create a dedicated plugin (separate repository). I'm not a Kotlin user myself, I took a crack at it while playing around with Kotlin.

There's really not much into it if you're familiar with OSGI, I based the Kotlin implementation on the Groovy support that I contributed previously (with help from Eric).

Personally, I have moved to LSP-java (emacs user here). Eclim served me well for many years, it was a great improvement over less reliable alternatives. Thank you for that @ervandew .

@dansomething dansomething mentioned this pull request Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin support
3 participants