Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions internal/jwk/jwk_parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,24 +76,23 @@ func (jwe jwkEntry) parseRSA() (*key, error) {
N: &n,
}

/* // there is no alg...
switch {
case jwe.RsaAlg == "RS256" && len(nbuf) == 256:
switch jwe.RsaAlg {
case "RS256":
return &key{pub: &r, hash: crypto.SHA256}, nil
case jwe.RsaAlg == "RS384" && len(nbuf) == 384:
case "RS384":
return &key{pub: &r, hash: crypto.SHA384}, nil
case jwe.RsaAlg == "RS512" && len(nbuf) == 512:
return &key{pub: &r, hash: crypto.SHA512}, nil
}
*/

switch len(nbuf) {
case 256:
return &key{pub: &r, hash: crypto.SHA256}, nil
case 384:
return &key{pub: &r, hash: crypto.SHA384}, nil
case 512:
case "RS512":
return &key{pub: &r, hash: crypto.SHA512}, nil
default:
// If we don't know RsaAlg
// we try to determine key len
switch len(nbuf) {
case 256:
return &key{pub: &r, hash: crypto.SHA256}, nil
case 384:
return &key{pub: &r, hash: crypto.SHA384}, nil
case 512:
return &key{pub: &r, hash: crypto.SHA512}, nil
}

return nil, ErrParse
Expand Down
33 changes: 15 additions & 18 deletions provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,21 @@ func (p *Provider) SetAuth(clientId, clientSecret, clientUrlRedirect string) err
// want to avoid parsing all the time
u, err := url.ParseRequestURI(p.clientUrlRedirect)
if err != nil {
return err
return fmt.Errorf("cannot parse callback URL: %v", err)
}
p.clientUrlRedirectPath = u.RequestURI()

// auth contains the jwk stuff
p.state, err = state.NewVerifier(clientId, clientSecret)
if err != nil {
return err
return fmt.Errorf("cannot verify client id and secret: %v", err)
}

p.jwk, err = jwk.MapFromUrl(p.urlJwks)
if err != nil {
return err
if !p.oauthOnly {
p.jwk, err = jwk.MapFromUrl(p.urlJwks)
if err != nil {
return fmt.Errorf("cannot parse callback URL: %v", err)
}
}

return nil
Expand Down Expand Up @@ -162,19 +164,17 @@ func (p *Provider) ValidateIdentityParamsWithUserdata(ctx context.Context, code,
// YES, we unpack again for fuck sake!
nonce, udata, err := p.state.ValidateWithData(cookie, state, DefaultStateTimeout)
if err != nil {
fmt.Printf("state '%s' is not valid: %v\n", state, err)
return nil, nil, err
return nil, nil, fmt.Errorf("invalid state: %v", err)
}

// authentification is finished since we don't have token ids etc..
if p.oauthOnly {
t, err = p.tokenRequestOauth(ctx, code, state)
if err != nil {
//fmt.Printf("TOKEN REQUEST OAUTH ERR: %v\n", err)
return nil, nil, err
return nil, nil, fmt.Errorf("cannot create oauth request: %v", err)
}

fmt.Printf("Tokens: %v\n", t)
//fmt.Printf("Tokens: %v\n", t)
return t, udata, nil
}

Expand All @@ -184,31 +184,28 @@ func (p *Provider) ValidateIdentityParamsWithUserdata(ctx context.Context, code,
// return the accesstoken & refresh token too
t, err = p.tokenRequest(ctx, code)
if err != nil {
return nil, nil, err
return nil, nil, fmt.Errorf("error requesting token: %v", err)
}

//fmt.Printf("%s\n", t)
fmt.Printf("Tokens: %v\n", t)
//fmt.Printf("Tokens: %v\n", t)

idt, err := token.Parse(t.IdToken)
if err != nil {
//panic(err)
return nil, nil, err
}

// create functions..
kid, blob, sig := idt.GetVerifyInfo()
err = p.jwk.Verify(kid, blob, sig)
if err != nil {
//panic(err)
return nil, nil, err
return nil, nil, fmt.Errorf("cannot verify jwk: %v", err)
}

// TODO here we verify the issuer, the aud, the nonce, etc.. etc.. etc..
err = p.validateIdToken(nonce, idt)
if err != nil {
//panic(err)
return nil, nil, err
return nil, nil, fmt.Errorf("cannot validate idToken: %v", err)
}

// show the token.
Expand All @@ -226,7 +223,7 @@ func GetProvider(cookie string) (string, error) {

e, err := state.ParseEnvelope(cookie)
if err != nil {
return nilstr, err
return nilstr, fmt.Errorf("cannot parse envelope: %v", err)
}

return e.GetProvider(), nil
Expand Down