-
Notifications
You must be signed in to change notification settings - Fork 271
Allows to get default user data from HTTP Headers #367
base: master
Are you sure you want to change the base?
Allows to get default user data from HTTP Headers #367
Conversation
When using shout behind a reverse-proxy with possibly user-authentication (scenario of using it within an enterprise auth-proxy) allows to get the default pre-filled user identity from HTTP headers.
@JocelynDelalande, you have a much deeper understanding of networks and HTTP protocol than me, can you give your thought (and any other brain dump that might be useful to record?) on this? Also, does that look like a bug fix or an enhancement to you? |
@lucamilanesio that's a good feature, definitely useful when using some SSO. Thanks :) Next step (I mean, in another PR) would be to do (optional and disabled by default) external auth : user login is provided in HTTP headers by reverse-proxy. I opened #482 just to keep it in mind. @lucamilanesio two questions:
|
return defValue | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that helper is unnecessary, you can handle the whole thing with a 3rd dict argument to this _.merge()
@lucamilanesio bump ? |
Why not simply use HTTP authentication? I don't see the need to implement custom headers. |
@xPaw It's not the same. Here we're getting default user information by a third-party (generally, the reverse-proxy itself, which may use HTTP basic/digest), then that third-party populate the custom HTTP header with informations about the user it knows. What I suggest for longer-term and another PR (external auth) is the same thing except we're not only pre-populating form data but actually logging-in the user by this mean. @xPaw I don't know if I'm clear in my explanations… am I ? :) |
When using shout behind a reverse-proxy with possibly user-authentication
(scenario of using it within an enterprise auth-proxy) allows to get
the default pre-filled user identity from HTTP headers.