Conversation
CT Test Results 1 files 11 suites 3m 23s ⏱️ Results for commit 0746c03. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
bjorng
left a comment
bjorng
left a comment
There was a problem hiding this comment.
Thanks for your pull request. All your changes look good to me but I saw an opportunity to do one more improvement.
(Please amend the commit and force-push.)
| @@ -427,7 +427,7 @@ all_but_zeroes_to_list(<<Byte,T/binary>>, Acc, Remaining) -> | |||
|
|
|||
| The compiler removes building of sub binaries in the second and third clauses, | |||
| and it adds an instruction to the first clause that converts `Buffer` from a | |||
| match context to a sub binary (or do nothing if `Buffer` is a binary already). | |||
| match context to a sub binary (or does nothing if `Buffer` is a binary already). | |||
There was a problem hiding this comment.
While you are at it, please also do the following change:
| match context to a sub binary (or does nothing if `Buffer` is a binary already). | |
| match context to a sub binary (or does nothing if `Buffer` is already a binary). |
(Suggested by my own language intuition to be a more natural wording and confirmed by asking an LLM.)
There was a problem hiding this comment.
Yes, that sounds better 👍
Co-authored-by: Maria Scott <maria-12648430@hnc-agency.org>
juhlig
force-pushed
the
fix_efficiency_guide_typos
branch
from
0418b0e to
0746c03
Compare
3 participants
No description provided.