Skip to content

Commit

Permalink
Remove outdated comments (jump-dev#1717)
Browse files Browse the repository at this point in the history
* Remove outdated comment

We retain `copy_names = true` for explicitness.

* Remove outdated comment.

This was fixed by JuliaLang/julia#29878
  • Loading branch information
odow authored Dec 30, 2018
1 parent cd8dbe5 commit ed2f732
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions src/JuMP.jl
Original file line number Diff line number Diff line change
Expand Up @@ -618,9 +618,7 @@ function operator_warn(model::Model)
"performance reasons, you should not add expressions in a loop. " *
"Instead of x += y, use add_to_expression!(x,y) to modify x in " *
"place. If y is a single variable, you may also use " *
"add_to_expression!(x, coef, y) for x += coef*y.", maxlog=1)
# NOTE: On Julia 1.0 (at least), maxlog=1 does not work correctly.
# See https://github.com/JuliaLang/julia/issues/28786.
"add_to_expression!(x, coef, y) for x += coef*y.", maxlog = 1)
end
end

Expand Down
2 changes: 0 additions & 2 deletions src/copy.jl
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ function copy_model(model::Model)
# `backend(model` and the indices of `backend(new_model)`.
index_map = MOI.copy_to(backend(new_model), backend(model),
copy_names = true)
# TODO copynames is needed because of https://github.com/JuliaOpt/MathOptInterface.jl/issues/494
# we can remove it when this is fixed and released

copy_single_variable_constraints(new_model.variable_to_lower_bound,
model.variable_to_lower_bound, index_map)
Expand Down

0 comments on commit ed2f732

Please sign in to comment.