Skip to content

Fix bilinear interpolation boundary handling to match Node and browser outputs #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Fix bilinear interpolation boundary handling to match Node and browser outputs #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9709179
Initial plan
Copilot Nov 24, 2025
dad5d5a
Initial plan for investigating frame_grabber differences
Copilot Nov 24, 2025
fc12af7
Fix bilinear interpolation to match ndarray-linear-interpolate bounda…
Copilot Nov 24, 2025
6039ab7
Fix TypeScript type import for ndarray-linear-interpolate in test
Copilot Nov 24, 2025
65f03c5
Revert bilinear interpolation changes - investigating real differences
Copilot Nov 24, 2025
67eb345
Add frame_grabber consistency tests comparing Node and browser scaleA…
Copilot Nov 24, 2025
175692f
Update test file comment to reflect actual finding that tests pass
Copilot Nov 24, 2025
499f40a
Add frame_grabber grab() tests using real fixture images
Copilot Nov 24, 2025
0c80d4b
Add Node vs Browser scaleAndCrop comparison tests - found boundary di…
Copilot Nov 25, 2025
41e389a
Add browser grab() test that outputs data for comparison with Node
Copilot Nov 25, 2025
b08a8df
Fix potential stack overflow in base64 encoding and consolidate fs im…
Copilot Nov 25, 2025
24eaf7b
Add npm scripts for running just frame-grabber tests
Copilot Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ dist/
lib/quagga.js
cypress/videos
.nyc_output
tmp/
1 change: 1 addition & 0 deletions cypress/e2e/browser.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ window.ENV = { development: true, production: false, node: false };
import '../../src/analytics/test/browser/result_collector.spec.ts';
import '../../src/input/test/browser/exif_helper.spec';
import '../../src/input/test/browser/camera_access.spec.ts';
import '../../src/input/test/browser/frame_grabber_grab.spec.ts';
import '../../src/common/test/browser/mediaDevices.spec.ts';
38 changes: 3 additions & 35 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@
"test:browser-all": "npm run cypress:run",
"test:import": "mocha test/test-import.mjs",
"test:node": "npx cross-env NODE_ENV=test ts-mocha -p test/tsconfig.json src/**/test/node/*.spec.* src/**/test/*.spec.* test/integration/**/*.spec.ts",
"test:node:frame-grabber": "npx cross-env NODE_ENV=test ts-mocha -p test/tsconfig.json src/input/test/node/frame_grabber_grab.spec.ts",
"test:browser:frame-grabber": "npx cross-env NODE_ENV=development BUILD_ENV=development NODE_OPTIONS=--openssl-legacy-provider cypress run --env BUILD_ENV=development --spec cypress/e2e/browser.cy.ts",
"test:require": "mocha test/test-require",
"test:module": "npm run test:require && npm run test:import",
"test": "npm run cypress:run && npx cross-env NODE_ENV=test BUILD_ENV=development ts-mocha -p test/tsconfig.json src/**/test/node/*.spec.* src/**/test/*.spec.* test/integration/**/*.spec.ts",
Expand Down
Loading