Skip to content

fix: updated the transactionhintsbag implementation #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: updated the transactionhintsbag implementation #822

wants to merge 2 commits into from

Conversation

DioBr4nd0
Copy link

closes #817 ,

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14311715155

Details

  • 13 of 15 (86.67%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.24%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/wallet.rs 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/mir/constant.rs 1 64.71%
ergotree-ir/src/mir/expr.rs 1 68.77%
ergotree-ir/src/chain/token.rs 5 72.88%
Totals Coverage Status
Change from base Build 14229308012: -0.03%
Covered Lines: 11517
Relevant Lines: 14720
💛 - Coveralls

sethdusek
sethdusek requested changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@sethdusek sethdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR! Please check review comments, and fix failing CI tests (rustfmt)

ergo-lib/src/wallet.rs
.into_iter()
.filter(|hint| matches!(hint, Hint::SecretProven(_)))
.collect();
.partition(|hint| matches!(hint, Hint::CommitmentHint(_)));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all CommitmentHints are secret, only OwnCommitment is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethdusek sethdusek sethdusek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TransactionHintsBag segregation
3 participants
@DioBr4nd0 @coveralls @sethdusek