I141 #211
I141 #211
Conversation
- BuildUnconfirmedBalance utility - BuildUnconfirmedBalanceSpec - MempoolSpec
- get confirmed balance (tokens) of address - get confirmed Balance (nanoErgs) of address
- get confirmed balance (tokens) of address - get confirmed Balance (nanoErgs) of address
oskin1
left a comment
oskin1
left a comment
There was a problem hiding this comment.
Same here. Duplicated changes.
@oskin1 retargeted PR to base_pr |
# Conflicts: # modules/explorer-api/src/main/scala/org/ergoplatform/explorer/http/api/v1/services/Mempool.scala # modules/explorer-api/src/test/scala/org/ergoplatform/explorer/v1/services/AddressesSpec.scala # modules/explorer-api/src/test/scala/org/ergoplatform/explorer/v1/services/MempoolSpec.scala
...plorer-api/src/main/scala/org/ergoplatform/explorer/http/api/v1/routes/AddressesRoutes.scala
Outdated
Show resolved
Hide resolved
...s/explorer-api/src/main/scala/org/ergoplatform/explorer/http/api/v1/services/Addresses.scala
Outdated
Show resolved
Hide resolved
.../explorer-api/src/main/scala/org/ergoplatform/explorer/http/api/v1/shared/MempoolProps.scala
Outdated
Show resolved
Hide resolved
| def totalBalanceOf_(address: Address): F[TotalBalance] = | ||
| for { | ||
| confirmed <- confirmedBalanceOf(address, 0) | ||
| unconfirmed <- memprops.getUnconfirmedBalanceByAddress(address, confirmed) | ||
| } yield TotalBalance(confirmed, unconfirmed) |
There was a problem hiding this comment.
It seems this method does the same thing as totalBalanceOf but in a less efficient way. memprops.getUnconfirmedBalanceByAddress operates on the same data from database as
offChainBalance <- uOutputRepo.sumUnspentByErgoTree(tree)
offChainAssets <- uAssetRepo.aggregateUnspentByErgoTree(tree)
The difference only is that old code aggregates balances inside DB and you does all this in the application's runtime.
I believe this doesn't solve the problem.
There was a problem hiding this comment.
@oskin1 this totalBalanceOf_ uses memprops.getUnconfirmedBalanceByAddress
which generates unconfirmed balance with reference to:
- (of new unconfirmed outputs in mempool)
- (confirmed outputs spent in mempool)
- and already calculated confirmed balance from confirmedBalanceOf(address, 0)
the old is not inclusive of mempool transactions
so memprops.getUnconfirmedBalanceByAddress(address, confirmed) using all that data; if you have 10Ergs, send 2Erg and received 3Erg your unconfirmed balance should be 11Erg
the old one doesn't return this expected value.
There was a problem hiding this comment.
Oh,got it. The old one includes outputs from unconfirmed transactions, so all you need to do is to sum unconfirmed inputs and subtract them from total unconfirmed balance.
There was a problem hiding this comment.
thats what I did the first time, it didn't work in cases when an address sends out & receives tokens during the same "confirmation period"
the algorithm to correctly get the new unconfirmed balance works something along the lines of:
foldLeft transactions(items => item(Tx)):
- determine if transaction is a debit/credit via inputErgoTree(source of funds) ☑️
- determine useable outputs:
- output.ergoTree != wallet.ergoTree || for debit transactions
- output.ergoTree == wallet.ergoTree || for credit transactions
defined in this utility:
BuildUnconfirmedBalance
There was a problem hiding this comment.
Can you elaborate why simple aggregation of unconfirmed inputs/outputs doesn't work?
You get the same set of inputs/outputs inside unconfirmed transactions, so the result should be the same, right?
Unconfirmed balance wrong when a payment is made
Resolves issues #177 #141