Update YesNo.php #13
Open
Update YesNo.php #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept capital-initial “Yes/No” and “Tak/Nie” in YesNo::cast() • Added “Yes” and “Tak” to TRUE_LIKE. • Added “No” and “Nie” to FALSE_LIKE. This makes the boolean cast more forgiving when consuming data that capitalises only the first letter, improving robustness of Shopware integrations without changing existing behaviour.
…g configurator settings - When no persisted parent exists, generate/set a parent product ID (using Uuid::randomHex()) on $swData and use it as parentId for all variants. - Fallback to variantListingConfig property check (instead of displayParent) to keep parent listing behavior compatible with newer Shopware versions. - For variants that don’t yet exist in SW, create configurator settings from their options with productId = resolved parent ID.
…g configurator settings
- Add filterProductsNotMatchingSkuPattern (filter not products and parts) - Hide attributes with hide metadata value - Disable default filterable attribute for new attributes - Use only selected brands (temporary)
- Category: inject the main category as tree root - Images: leave the original name as a prefix - Change default: DEFAULT_STOCK_VALUE to "0", DEFAULT_GROSS_PRICE to "99999", minPurchaseMapping to "1"
- update composer version
daniel-memo-ict
requested changes
Sep 29, 2025
Collaborator
daniel-memo-ict
left a comment
daniel-memo-ict
left a comment
There was a problem hiding this comment.
Hi @devEcommercePL,
Unfortunately I can't accept this PR as it currently is. This PR now contains a lot more changes than just a few additions to the YesNo class. Please revert it to your initial commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept capital-initial “Yes/No” and “Tak/Nie” in YesNo::cast()
• Added “Yes” and “Tak” to TRUE_LIKE.
• Added “No” and “Nie” to FALSE_LIKE.
This makes the boolean cast more forgiving when consuming data that capitalises only the first letter, improving robustness of Shopware integrations without changing existing behaviour.