fix: "ignored_view_names" arg on "add_pyramid_paths" function has no effect#29
Open
GaNiziolek wants to merge 2 commits intoergo:masterfrom
Open
fix: "ignored_view_names" arg on "add_pyramid_paths" function has no effect#29GaNiziolek wants to merge 2 commits intoergo:masterfrom
GaNiziolek wants to merge 2 commits intoergo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing the arg "ignored_view_names" on function "add_pyramid_paths" has not effect.
On line 117, the value of "ignored_view_names" was passed to the kwarg "ignored_views", but the function "should_ignore_view" on line 139 was looking for the kwarg "ignored_view_names", so values passed to be ignored were never read .
I also wrote tests for this.
And add python 3.10 on tox