[cleanup] Remove TagsManager::AreTheSame/Language::FunctionFromPattern
#3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tern` which always return `false`. And then empty functions.
Jarod42
commented
Jan 30, 2025
| @@ -64,17 +64,7 @@ wxString CppCommentCreator::FunctionComment() | |||
| for(size_t i = 0; i < tags.size(); i++) | |||
| comment << wxT(" * ") << m_keyPrefix << wxT("param ") << tags.at(i)->GetName() << wxT("\n"); | |||
|
|
|||
| if(m_tag->GetKind() == wxT("function")) { | |||
| clFunction f; | |||
| if(lang->FunctionFromPattern(m_tag, f)) { | |||
There was a problem hiding this comment.
Always false, so dead code.
| @@ -215,9 +214,6 @@ void clCallTip::FormatTagsToTips(const TagEntryPtrVector_t& tags, std::vector<cl | |||
|
|
|||
| wxString raw_sig(t->GetSignature().Trim().Trim(false)); | |||
|
|
|||
| // evaluate the return value of the tag | |||
| cti.retValue = TagsManagerST::Get()->GetFunctionReturnValueFromPattern(t); | |||
There was a problem hiding this comment.
returned always wxEmptyString
| wxString TagsManager::FormatFunction(TagEntryPtr tag, size_t flags, const wxString& scope) | ||
| { | ||
| clFunction foo; | ||
| if(!GetLanguage()->FunctionFromPattern(tag, foo)) { |
There was a problem hiding this comment.
Always false, so return always wxEmptyString
| // evaluate the return value of the tag | ||
| clFunction foo; | ||
| wxString return_value; | ||
| if(GetLanguage()->FunctionFromPattern(tag, foo)) { |
There was a problem hiding this comment.
Always false, so return always wxEmptyString
| @@ -177,10 +177,6 @@ void SymbolTree::BuildTree(const wxFileName& fileName, const TagEntryPtrVector_t | |||
| // Load the new tags from the database | |||
| db->SelectTagsByFile(fileName.GetFullPath(), newTags); | |||
|
|
|||
| // Compare the new tags with the old ones | |||
| if(!forceBuild && TagsManagerST::Get()->AreTheSame(newTags, m_currentTags)) | |||
There was a problem hiding this comment.
Always false, so dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which always return
false.And then empty functions.