Fix GenC tail rec elimination for unit functions when body is not in Block#1640
Open
zhekai-jiang wants to merge 1 commit intoepfl-lara:mainfrom
Open
Fix GenC tail rec elimination for unit functions when body is not in Block#1640zhekai-jiang wants to merge 1 commit intoepfl-lara:mainfrom
zhekai-jiang wants to merge 1 commit intoepfl-lara:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix a newly-discovered subtle bug, following #1626. Essentially for
Unitfunctions without areturnstatement, we add a return statement at the end so that it is not rewritten into an infinitewhileloop. We assumed before that all functions have body wrapped in aBlockobject, but actually this may not be the case.(Interestingly, we didn’t change any test case, and it was not an issue on our x86/64 laptops and on CI (function bodies were always wrapped in
Blocks). But I accidentally got an issue when I was testing things on a different Mac with Apple Silicon (ARM architecture), where sometimes if the function has, say, only anIfstatement, the body will simply be thatIfobject instead of thatIfwrapped inside aBlockobject.)