Feature/EPMUII-10417 Configure e2e tests on playwright#222
Merged
rrodionov91 merged 19 commits intodevelopfrom Apr 13, 2025
Merged
Feature/EPMUII-10417 Configure e2e tests on playwright#222rrodionov91 merged 19 commits intodevelopfrom
rrodionov91 merged 19 commits intodevelopfrom
Conversation
- created folder and docker config for e2e tests
- added serve for prod build - configured docker for app and tests run - added github workflow for e2e tests
- added github workflow for e2e tests
- changed node version on gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
- test gh workflow
rrodionov91
force-pushed
the
feature/EPMUII-10417-Configure_e2e_tests_on_playwright
branch
from
57ffad2 to
82057d9
Compare
alterfo
approved these changes
Apr 3, 2025
Comment on lines
+3
to
+9
| /** | ||
| * Read environment variables from file. | ||
| * https://github.com/motdotla/dotenv | ||
| */ | ||
| // import dotenv from 'dotenv'; | ||
| // import path from 'path'; | ||
| // dotenv.config({ path: path.resolve(__dirname, '.env') }); |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * Read environment variables from file. | |
| * https://github.com/motdotla/dotenv | |
| */ | |
| // import dotenv from 'dotenv'; | |
| // import path from 'path'; | |
| // dotenv.config({ path: path.resolve(__dirname, '.env') }); |
Collaborator
Author
There was a problem hiding this comment.
It is default generated comment. We are not going to introduce env variables in current PR
alterfo
reviewed
Apr 3, 2025
| // baseURL: 'http://127.0.0.1:3000', | ||
|
|
||
| /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ | ||
| trace: 'off', |
Contributor
There was a problem hiding this comment.
Suggested change
| trace: 'off', | |
| trace: 'on-first-retry', | |
| screenshot: 'only-on-failure', |
Collaborator
Author
There was a problem hiding this comment.
Traces increase the report size dramatically. According to my experience they are not so useful because every report contains test steps log and it is easy to run it locally with debug option if needed (usually not often). So I'm going to keep it off in this PR
alterfo
reviewed
Apr 3, 2025
.github/workflows/playwright.yml
Outdated
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16 |
Contributor
There was a problem hiding this comment.
Suggested change
| node-version: 16 | |
| node-version: 18 |
alterfo
reviewed
Apr 3, 2025
e2e-tests/Dockerfile-app
Outdated
| @@ -0,0 +1,8 @@ | |||
| FROM node:16-bullseye-slim | |||
Contributor
There was a problem hiding this comment.
Suggested change
| FROM node:16-bullseye-slim | |
| FROM node:18-bullseye-slim |
- fixed failed test - updated package-lock after rebase - removed excessive operations in test running scripts
- fixed failed test - updated package-lock after rebase - removed excessive operations in test running scripts - added shutting services down after test execution - added prepare scripts for tests
- fixed tests build
rrodionov91
changed the title
- added docs - fixed test parametrization
- fixed docs
DanilRostov
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.