Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: adds cost specifier to RateLimitRule #4957
api: adds cost specifier to RateLimitRule #4957
Changes from 13 commits
a5cd77a
7fd2ae3
2f3cd27
487d68b
ca56b4d
67791da
70e1a72
bf674e5
29010ea
7d15bf8
e6fd792
641a70e
57290ad
0d506e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it is still required to specify the number of requests limit, how we can handle the case when we only care of the cost not the number of the request limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so first of all, this
limit
is nothing to do with that purpose. And to do the limit purely on the token number (in this context response cost only), you can simply set thecost.response = {from: Number, Number: 0}
as per the comment - zero can be used to "only check the budget and if not left anything, then reject".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also with this new
cost
field,limit.requests
doesnt quite fit anymore, something likelimit.total
feels better and can be an alias tolimit.requests
in the future to improve defining intentSome generated files are not rendered by default. Learn more about how customized files appear on GitHub.