grpc_json_transcoder: when sse delimiter is on, make sure unary calls get content-type application/json #41594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypnoce
force-pushed
the
unary_sse_content_type
branch
from
79bea33 to
8e6092f
Compare
… get content-type application/json. This aligns with grpc-httpjson-transcoding where body is sse encoded only for streaming requests. Fixes envoyproxy#41593 Signed-off-by: hypnoce <[email protected]>
hypnoce
force-pushed
the
unary_sse_content_type
branch
from
8e6092f to
1e5dfd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: grpc_json_transcoder: when sse delimiter is on, make sure unary calls get content-type application/json This aligns with grpc-httpjson-transcoding where body is sse encoded only for streaming requests. Fixes #41593
Additional Description:
Risk Level: Low
Testing: added TranscodingStreamSSEUnary test
Docs Changes: No
Release Notes: grpc_json_transcoder : when sse delimiter is on, make sure unary calls get content-type application/json
Platform Specific Features: No