dfp: deprecate flag dfp_cluster_resolves_hosts and remove legacy code paths #41557
+15
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawroh
requested review from
RyanTheOptimist and
mattklein123
as code owners
… paths Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
depcr-dfp_cluster_resolves_hosts
branch
from
ab684a4 to
a404f0d
Compare
|
I think there was a related bug that I'm trying to see if it was addressed or not. |
I will merge hold until we confirm and will re-assign the ticket to you to keep track. |
|
/wait-any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated reloadable flag
dfp_cluster_resolves_hostsand cleans up the legacy paths.Fix #41503
Commit Message: dfp: deprecate flag dfp_cluster_resolves_hosts and remove legacy code paths
Additional Description: Remove the deprecated reloadable flag
dfp_cluster_resolves_hostsand cleans up the legacy paths.Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: Added