Skip to content

Conversation

agrawroh
Copy link
Member

Description

This PR removes the deprecated reloadable flag async_host_selection and cleans up the legacy paths.

Fix #41502


Commit Message: router: deprecate flag async_host_selection and remove legacy code paths
Additional Description: Remove the deprecated reloadable flag async_host_selection and cleans up the legacy paths.
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: Added

…election and legacy code branches

Signed-off-by: Rohit Agrawal <[email protected]>
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #41538 was opened by agrawroh.

see: more, trace.

Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential issue for this feature but could be addressed by the last CVE release, and would like to keep it one more release.

@botengyao
Copy link
Member

/wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_async_host_selection deprecation

2 participants