Skip to content

Conversation

adisuissa
Copy link
Contributor

Commit Message: endpoints: refactor Locality data-members to be shared from pool
Additional Description:
At the moment each host (endpoint) has a copy of its locality. This refactor allows a locality to be shared across host objects, so they all point to the same resource, instead of having their own copy.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41447 was opened by adisuissa.

see: more, trace.

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Only some minor comments. And would be better to delay this merging until 1.36 is released.

@wbpcode
Copy link
Member

wbpcode commented Oct 15, 2025

/retest

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants