Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code_format: allow skipping build fixer #37811

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

ohadvano
Copy link
Contributor

Commit Message: Adding an option to skip running build fixer script in case only linting is required
Risk Level: low
Testing: none
Docs Changes: none
Release Notes: none
Platform Specific Features: none

Signed-off-by: ohadvano <[email protected]>
@ohadvano
Copy link
Contributor Author

/assign @phlax

Signed-off-by: ohadvano <[email protected]>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ohadvano

as discussed offline this wont be necessary shortly as i have some pending code to separate this from this tool altogether

@phlax phlax merged commit 1c15655 into envoyproxy:main Jan 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants