Skip to content

bazel: Patch aspect lib to resolve external build issue #30453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 24, 2023

upstream issue is bazel-contrib/bazel-lib#548 pr is: bazel-contrib/bazel-lib#547

Currently the websites and archive patch this independently

This caused a breakage (in all 3) when aspect lib was updated

envoyproxy/envoy-website#368

This should prevent that until there is some upstream resolution

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 24, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #30453 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Oct 24, 2023

/retest

@phlax phlax changed the title bazel/patch: Patch aspect lib to resolve external build issue bazel: Patch aspect lib to resolve external build issue Oct 24, 2023
upstream issue is bazel-contrib/bazel-lib#548
pr is: bazel-contrib/bazel-lib#547

Currently the websites and archive patch this indepenendently

This caused a breakage (in all 3) when aspect lib was updated

envoyproxy/envoy-website#368

This should prevent that until there is some upstream resolution

Signed-off-by: Ryan Northey <[email protected]>
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 24, 2023
@phlax phlax enabled auto-merge (squash) October 24, 2023 14:09
@phlax phlax merged commit e2a509e into envoyproxy:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants