Add cancellation support to session::tokio functions#100
Merged
fjarri merged 1 commit intoentropyxyz:masterfrom May 21, 2025
Merged
Add cancellation support to session::tokio functions#100fjarri merged 1 commit intoentropyxyz:masterfrom
session::tokio functions#100fjarri merged 1 commit intoentropyxyz:masterfrom
Conversation
Contributor
Author
|
@peg FYI |
Pull Request Test Coverage Report for Build 14842568648Details
💛 - Coveralls |
dvdplm
approved these changes
May 5, 2025
Contributor
dvdplm
left a comment
There was a problem hiding this comment.
I am no expert on tokio but afaik using cancellation tokens like this is idiomatic and the code looks good to me.
As for the question I need to research it a bit more; I honestly don't know what the idiomatic pattern is for deadlines/timeouts. It sounds plausible that cancellation tokens are part of the right answer, but it also seems like there'd a higher level API that we should be using?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow users to impose an external timeout (or to cancel the session loop manually, e.g. on keyboard interrupt).
Also fixed some error processing lapses in
par_run_session()where closing of the incoming message channel (or internal channels) was silently ignored.The timeout support (#12) is still under consideration. The cancellation takes care of the global timeout, or any other cases where the execution needs to be terminated gracefully, but we may still need some partial cutoff times for specific rounds (not clear at this point what the API would be).