Skip to content

fix: guard handle_pat_check against deregistered hotkey TOCTOU race (#1297) #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alpurkan17 wants to merge 1 commit into from
+5 −0
Closed

fix: guard handle_pat_check against deregistered hotkey TOCTOU race (#1297) #1301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gittensor/validator/pat_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ async def priority_pat_broadcast(validator: 'Validator', synapse: PatBroadcastSy
async def handle_pat_check(validator: 'Validator', synapse: PatCheckSynapse) -> PatCheckSynapse:
"""Check if the validator has the miner's PAT stored and re-validate it."""
hotkey = _get_hotkey(synapse)
if hotkey not in validator.metagraph.hotkeys:
synapse.has_pat = False
synapse.pat_valid = False
synapse.rejection_reason = 'Hotkey not registered on subnet'
return synapse
uid = validator.metagraph.hotkeys.index(hotkey)
entry = pat_storage.get_pat_by_uid(uid)

Expand Down
Loading