Skip to content

fix(validator): move valid_solved increment after exclusion guards #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enjoyandlove wants to merge 1 commit into
base: test
Choose a base branch
from
+6 −4
Open

fix(validator): move valid_solved increment after exclusion guards #1299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions gittensor/validator/issue_discovery/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,10 +456,6 @@ async def _score_miner_issues(
)
continue

# Valid-solved gate: solving PR must meet the repo's token threshold.
if cached.token_score >= cfg.min_token_score_for_valid_issue:
acc.valid_solved += 1

# Same-account: discoverer == solver gets credibility only, no score
if issue.author_github_id == solving_pr.author_github_id:
bt.logging.debug(
Expand All @@ -477,6 +473,12 @@ async def _score_miner_issues(
)
continue

# Valid-solved gate: solving PR must meet the repo's token threshold.
# Placed after exclusion guards so same-account and non-canonical issues
# do not inflate the counter and bypass the eligibility check.
if cached.token_score >= cfg.min_token_score_for_valid_issue:
acc.valid_solved += 1

# Quality gate: below-threshold solving PRs add credibility only, no
# discovery score.
if cached.token_score < cfg.min_token_score_for_valid_issue:
Expand Down