fix: keep issue discovery scoring when open-count fetch fails#1254
Closed
Matsx901 wants to merge 1 commit into
Closed
fix: keep issue discovery scoring when open-count fetch fails#1254Matsx901 wants to merge 1 commit into
Matsx901 wants to merge 1 commit into
Conversation
Collaborator
|
Closing — see #1251 for the documented copying of @seroperson's Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1249.
Issue discovery currently restores cached issue-discovery fields and skips a miner when the secondary open-issue count fetch fails, even if the primary lookback fetch already succeeded. This discards fresh solved-issue evidence because the open-count request is treated as a hard dependency.
This change keeps the successful scoring response and only falls back the open-count input.
Root Cause
run_issue_discovery()performs two mirror requests per miner:The second request failure path restored cached issue-discovery fields and continued, so fresh solved/valid-solved data from the first request was ignored.
Changes
total_open_issueswhen available.Out of scope
Type of Change
Testing