fix: resolve usdPerDay mismatch between miner list and detail APIs#1242
Open
Kelvinchen03 wants to merge 1 commit into
Open
fix: resolve usdPerDay mismatch between miner list and detail APIs#1242Kelvinchen03 wants to merge 1 commit into
Kelvinchen03 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed inconsistent usdPerDay display values between the leaderboard (/repositories) and miner details (/miners/details) pages. The issue was caused by different API responses returning slightly different values (e.g., 123.60 vs 123.08), which when rounded with Math.round() resulted in different displayed values ($124 vs $123).
Solution: Centralized USD/day formatting logic by creating a shared formatUsdPerDay() utility function that uses consistent rounding behavior (.toFixed(0)) across all components.
Related Issues
Fixes #1241
Type of Change
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses