feat: miners leaderboard username sort#1217
Open
andriypolanski wants to merge 4 commits into
Open
Conversation
Contributor
Author
Collaborator
|
Please provide screenshots or other visual media follow contributing.md |
Contributor
Author
|
I just uploaded screenshots, please review again. |
…ub.com/andriypolanski/gittensor-ui into feat/miners-leaderboarad-username-sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The miners leaderboard could be sorted by score, earnings, activity counts, and credibility, but not by miner name. Users looking up a GitHub login had to rely on search alone. The repositories leaderboard already supports Repository sort (A→Z, URL state, list header click); miners had no equivalent for identity.
Related Issues
Closes #1216
Type of Change
Screenshots
Before
before.mp4
After
after.mp4
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpassesSolution
Introduce a
usernameSortOptionthat sorts miners alphabetically by GitHub login, following the same pattern asrepositoryonTopRepositoriesTable.Files
src/components/leaderboard/types.tsusernamesort key;minerSortNamehelpersrc/components/leaderboard/TopMinersTable.tsxsrc/components/leaderboard/MinersList.tsxsortKey: 'username'src/components/leaderboard/index.tsminerSortName